[webkit-reviews] review granted: [Bug 39688] We should check if a DB needs to be auto-vacuumed only after transactions that delete something : [Attachment 57601] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 1 15:59:46 PDT 2010
Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 39688: We should check if a DB needs to be auto-vacuumed only after
transactions that delete something
https://bugs.webkit.org/show_bug.cgi?id=39688
Attachment 57601: patch
https://bugs.webkit.org/attachment.cgi?id=57601&action=review
------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
r=me, except for:
> - return denyBasedOnTableName(tableName);
> + bool allow = denyBasedOnTableName(tableName);
> + m_hadDeletes |= allow;
> + return allow;
This looks like a neat helper function.
More information about the webkit-reviews
mailing list