[webkit-reviews] review requested: [Bug 37804] [Qt] Image shadow doesn't work in Qt : [Attachment 57593] patch5

[bugzilla-daemon at webkit.org]

qi <qi.2.zhang at nokia.com> has asked  for review:
Bug 37804: [Qt] Image shadow doesn't work in Qt
https://bugs.webkit.org/show_bug.cgi?id=37804

Attachment 57593: patch5
https://bugs.webkit.org/attachment.cgi?id=57593&action=review

------- Additional Comments from qi <qi.2.zhang at nokia.com>
1. Change the variable name based on the Dirk's comment;
2. Remove canvas/philip/tests/2d.shadow.image.basic.html from Skipped list;
3. Add canvas/philip/tests/2d.shadow.image.transparent.1.html into Skipped
list;
   The reason is: This case using a transparent image, which Qt display as a
black image. 
   This is known issue on: http://bugreports.qt.nokia.com/browse/QTBUG-9072
   Based on spec, if the image is transparent, we should not draw shadow for
it. Before this
   patch, we didn't draw image shadow, so it pass this case. But after this
patch, we will
   draw image shadow, somehow Qt display it as a black image instead of the
transparent, that
   cause us to draw a shadow! So, this is not canvas issue, it is Qt issue.