[webkit-reviews] review canceled: [Bug 40003] [Qt] Fix the lifecycle of notification objects : [Attachment 57554] Patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 1 13:31:43 PDT 2010
Yael <yael.aharon at nokia.com> has canceled Yael <yael.aharon at nokia.com>'s
request for review:
Bug 40003: [Qt] Fix the lifecycle of notification objects
https://bugs.webkit.org/show_bug.cgi?id=40003
Attachment 57554: Patch.
https://bugs.webkit.org/attachment.cgi?id=57554&action=review
------- Additional Comments from Yael <yael.aharon at nokia.com>
Rename addPage/removePage/m_pageCount to addClient/removeClient/m_clientCount
and make the timeout a static global.
I did not define the notification presenter with DEFINE_STATIC_LOCAL, because I
could not find a way to delete it if I made it a static in a local function.
Please advice if there is a way to do that.
More information about the webkit-reviews
mailing list