[webkit-reviews] review requested: [Bug 39958] [Qt] TextBreakIteratorQt performance : [Attachment 57586] Patch, lets try this again.

[bugzilla-daemon at webkit.org]

David Leong <david.leong at nokia.com> has asked  for review:
Bug 39958: [Qt] TextBreakIteratorQt performance
https://bugs.webkit.org/show_bug.cgi?id=39958

Attachment 57586: Patch, lets try this again.
https://bugs.webkit.org/attachment.cgi?id=57586&action=review

------- Additional Comments from David Leong <david.leong at nokia.com>
Thanks for the review again Kenneth, Simon :)

Updated the patch to use StringImpl's hash as a key to the cached
TextBreakIterator. The hash is calculated only once as needed and can be used
to identify the string. If the hash and search type is the same, then we
re-used the iterator. 

There is no dependency on the string pointer anymore, so it should not crash in
the case the string pointer is ever reused with a string that has the same
length but different content.

I overloaded the TextBreakIterator functions instead of changing all of them, I
am worried it may break other port's builds.