[webkit-reviews] review requested: [Bug 39382] Factor PageCache code out of FrameLoader into a PageCacheController : [Attachment 57582] One option for a crash fix

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 39382: Factor PageCache code out of FrameLoader into a PageCacheController
https://bugs.webkit.org/show_bug.cgi?id=39382

Attachment 57582: One option for a crash fix
https://bugs.webkit.org/attachment.cgi?id=57582&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
So the crash in DocumentLoader::isLoadingInAPISense is triggered by trying to
deref m_frame->document() when it is null.  The trivial fix for this is
attached (null checking before using m_frame->document()). 

I make no claims that this is the right solution, but it's one option.	On the
one hand, the return value of Frame::document() is not guaranteed to be valid
and it gets null checked a bunch of other places.  On the other hand, I have
yet to figure out what changed that we are hitting null cases now (I'm guessing
I inadvertently changed some timing/ordering).