[webkit-reviews] review granted: [Bug 39041] Move the code that should be shared by sync and async DBs to a separate class : [Attachment 56032] patch #2: clean up

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 39041: Move the code that should be shared by sync and async DBs to a
separate class
https://bugs.webkit.org/show_bug.cgi?id=39041

Attachment 56032: patch #2: clean up
https://bugs.webkit.org/attachment.cgi?id=56032&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Looks great!  Nice work.

WebCore/storage/Database.h:55
 +  class SecurityOrigin;
I don't think we need the NDEBUG conditional here.  It's not a terrible thing
to forward declare this class.

WebCore/storage/DatabaseTask.cpp: 
 +	    MutexLocker
locker(m_transaction->database()->m_transactionInProgressMutex);
Not 100% sure why we lost this mutex here, but ok.

WebCore/storage/Database.cpp:660
 +	MutexLocker locker(m_transactionInProgressMutex);
Oh, I see.  It went here.