[webkit-reviews] review granted: [Bug 39324] AX: WebKit doesn't call [super -accessibilityAttributeValue:attribute forParameter:] when it encounters a parameterized attribute that it doesn't handle. : [Attachment 57347] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 1 11:25:30 PDT 2010


Beth Dakin <bdakin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 39324: AX: WebKit doesn't call [super
-accessibilityAttributeValue:attribute forParameter:] when it encounters a
parameterized attribute that it doesn't handle.
https://bugs.webkit.org/show_bug.cgi?id=39324

Attachment 57347: Patch
https://bugs.webkit.org/attachment.cgi?id=57347&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
I am going to r+ this, but do you think there is any particular reason why this
should be a goto instead of a regular function call? I shy away from using
gotos since there aren't a lot of them in the code, but since we don't have an
official policy, r+ anyway. I would like it if you would answer my question
though ;-)


More information about the webkit-reviews mailing list