[webkit-reviews] review canceled: [Bug 39997] [Gtk] Make sure DRT return the right AXTitle for controls : [Attachment 57544] Proposed patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has canceled Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 39997: [Gtk] Make sure DRT return the right AXTitle for controls
https://bugs.webkit.org/show_bug.cgi?id=39997

Attachment 57544: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=57544&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #3)
> (From update of attachment 57544 [details])
> 
> > -	 return JSStringCreateWithUTF8CString(name);
> > +	 gchar* title = g_strdup_printf("AXTitle: %s", name);
> > +	 JSStringRef jsTitle = JSStringCreateWithUTF8CString(title);
> > +
> > +	 g_free(title);
> > +	 return jsTitle;
> 
> You can use GOwnptr here for title.

Thanks Martin for your comments, which have been addressed in the patch
proposed for bug 40009 as at the end I thought it would be better to follow a
different approach with this problem and split it in two parts:

 1. Make GTK's DRT more coherent with other ports (bug 40009)
 2. Actually make sure the AXTitle for controls is properly calculated and
returned, to unskip the proper test

So here we are the patch for (2), patch for (1) already attached along with bug
40009