[webkit-reviews] review denied: [Bug 39878] [Qt]: REGRESSION(r58703): QWebSettings::JavascriptCanAccessClipboard has wrong case in "Javascript" part. : [Attachment 57456] 2nd proposal for fixing QWebSettings::JavascriptCanAccessClipboard enum.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 1 03:26:27 PDT 2010


Simon Hausmann <hausmann at webkit.org> has denied Raine Makelainen
<raine.makelainen at nokia.com>'s request for review:
Bug 39878: [Qt]: REGRESSION(r58703): QWebSettings::JavascriptCanAccessClipboard
has wrong case in "Javascript" part.
https://bugs.webkit.org/show_bug.cgi?id=39878

Attachment 57456: 2nd proposal for fixing
QWebSettings::JavascriptCanAccessClipboard enum. 
https://bugs.webkit.org/attachment.cgi?id=57456&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Thanks Raine :)

I think the patch looks good, but please add ChangeLog entries. You can use
WebKitTools/Scripts/prepare-ChangeLog for that. r- because of that, the rest
looks good to me.


More information about the webkit-reviews mailing list