[webkit-reviews] review granted: [Bug 39972] Fix style errors of dtoa : [Attachment 57498] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 1 01:30:02 PDT 2010


Shinichiro Hamaji <hamaji at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 39972: Fix style errors of dtoa
https://bugs.webkit.org/show_bug.cgi?id=39972

Attachment 57498: Patch
https://bugs.webkit.org/attachment.cgi?id=57498&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
> I don't like to change to the reference unless you have a strong objection. 
I believe returning updated pointer has better code readability.

Hmm I slightly prefer the reference so that we won't forget to assign the
return value, but it's not a strong objection. Please feel free to land this
patch as is.


More information about the webkit-reviews mailing list