[webkit-reviews] review denied: [Bug 21937] h1:first-letter is incorrectly inherited by run-in box : [Attachment 57749] Proposed Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Yoshiki Hayashi
<yhayashi at google.com>'s request for review:
Bug 21937: h1:first-letter is incorrectly inherited by run-in box
https://bugs.webkit.org/show_bug.cgi?id=21937

Attachment 57749: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=57749&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
LayoutTests/fast/css/first-letter-after-run-in-expected.txt:1
 +  not-capitalized
Can you use the script-tests framework, to create a better testcase, that
actually tells what you're checkink. Of course it's clear from the testcase,
but I think you could do better and explicitely explain what's happening, in
the expected-txt output.

Can't review the actual RenderBlock change, you'll need to ask rendering gurus
for that (Dave Hyatt / Dan Bernstein..)