[webkit-reviews] review granted: [Bug 43271] Short documents may print a second blank page : [Attachment 63138] Use the page height as the viewport height when printing
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 30 21:57:54 PDT 2010
Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 43271: Short documents may print a second blank page
https://bugs.webkit.org/show_bug.cgi?id=43271
Attachment 63138: Use the page height as the viewport height when printing
https://bugs.webkit.org/attachment.cgi?id=63138&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> +void Frame::setPrinting(bool printing, float pageWidth, float pageHeight,
float maximumShrinkRatio, AdjustViewSizeOrNot shouldAdjustViewSize)
I'd prefer const FloatSize& pageSize. Will that work?
> // This magic is basically copied from khtmlview::print
Wow, you are leaving this comment!?
> + void forceLayoutForPagination(float pageWidth, float pageHeight, float
maximumShrinkFactor, Frame::AdjustViewSizeOrNot);
I'd prefer const FloatSize& pageSize here too. Make sense?
> + void begin(float width, float height = 0);
What about here? FloatSize?
> -2010-07-30 Joseph Pecoraro <joepeck at webkit.org>
> +2010-07-30 Dan Bernstein <mitz at apple.com>
You removed Joe's change log entry!
More information about the webkit-reviews
mailing list