[webkit-reviews] review granted: [Bug 43282] The currentItem fixup done by BackForwardList::pushStateItem should be moved into HistoryController::pushState : [Attachment 63124] v1 patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 30 18:16:09 PDT 2010


Darin Adler <darin at apple.com> has granted Darin Fisher (:fishd, Google)
<fishd at chromium.org>'s request for review:
Bug 43282: The currentItem fixup done by BackForwardList::pushStateItem should
be moved into HistoryController::pushState
https://bugs.webkit.org/show_bug.cgi?id=43282

Attachment 63124: v1 patch
https://bugs.webkit.org/attachment.cgi?id=63124&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -    HistoryItem* targetItem = m_frame->loader()->history()->currentItem();

LOL, m_frame->loader()->history() is a roundabout way of writing "this"!


More information about the webkit-reviews mailing list