[webkit-reviews] review denied: [Bug 43213] ctx.clearRect improperly clears shadow : [Attachment 63114] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 30 16:00:44 PDT 2010
Darin Adler <darin at apple.com> has denied Matthew Delaney <mdelaney at apple.com>'s
request for review:
Bug 43213: ctx.clearRect improperly clears shadow
https://bugs.webkit.org/show_bug.cgi?id=43213
Attachment 63114: Patch
https://bugs.webkit.org/attachment.cgi?id=63114&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> + state().m_globalAlpha = (float)1.0;
Our consensus on best practice is to just put "1" in cases like this. If you
really want a float, then 1.0f is the way to do it. (float)1.0 is not preferred
style.
> + context->setAlpha((float)1.0);
Ditto.
More information about the webkit-reviews
mailing list