[webkit-reviews] review requested: [Bug 42843] Interrupt all DB operations when a worker is shutting down : [Attachment 63108] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 30 15:04:05 PDT 2010


Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 42843: Interrupt all DB operations when a worker is shutting down
https://bugs.webkit.org/show_bug.cgi?id=42843

Attachment 63108: patch
https://bugs.webkit.org/attachment.cgi?id=63108&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
same patch, with one minor change. the ASSERT in SQLiteDatabase::close() was
commented out before this patch. i thought it would be ok to uncomment it, but
turns out i was wrong -- it's ok to uncomment it for WebSQLDatabases, but
there's other code that doesn't close the database on the same thread that
opened it. so i left that ASSERT commented out as it was before.


More information about the webkit-reviews mailing list