[webkit-reviews] review granted: [Bug 43135] Decouple FileThread from FileStream to support generic file-related async tasks : [Attachment 62903] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 30 14:44:25 PDT 2010
Jian Li <jianli at chromium.org> has granted Kinuko Yasuda <kinuko at chromium.org>'s
request for review:
Bug 43135: Decouple FileThread from FileStream to support generic file-related
async tasks
https://bugs.webkit.org/show_bug.cgi?id=43135
Attachment 62903: Patch
https://bugs.webkit.org/attachment.cgi?id=62903&action=review
------- Additional Comments from Jian Li <jianli at chromium.org>
Looks good. Please address the following issue before you land.
WebCore/html/FileThreadTask.h:
+ R (FileStream::*method)());
Why removing this? I think this forward declaration is needed to get rid of the
warning treater as error in snow leopard. See
http://trac.webkit.org/changeset/59166 for detail.
More information about the webkit-reviews
mailing list