[webkit-reviews] review granted: [Bug 43268] Implement NPN_Evaluate : [Attachment 63098] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 43268: Implement NPN_Evaluate
https://bugs.webkit.org/show_bug.cgi?id=43268

Attachment 63098: Patch
https://bugs.webkit.org/attachment.cgi?id=63098&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>

> +    bool evaluate(NPObject*, const WebCore::String &scriptString, NPVariant*
result);

& on the wrong side.

> +
>      void setStatusbarText(const WebCore::String&);
> +    bool evaluate(NPObject*, const WebCore::String &scriptString, NPVariant*
result);

Here too.


> +    // Evaluates the given script string in the context of the given
NPObject.
> +    virtual bool evaluate(NPObject*, const WebCore::String &scriptString,
NPVariant* result, bool allowPopups) = 0;
> +

And here too.


>  
> +bool PluginView::evaluate(NPObject* npObject, const String &scriptString,
NPVariant* result, bool allowPopups)
> +{

And again.

> +    virtual bool evaluate(NPObject*, const WebCore::String &scriptString,
NPVariant* result, bool allowPopups);
Once more!

r=me