[webkit-reviews] review granted: [Bug 43213] ctx.clearRect improperly clears shadow : [Attachment 63095] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 30 13:14:05 PDT 2010


Darin Adler <darin at apple.com> has granted Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 43213: ctx.clearRect improperly clears shadow
https://bugs.webkit.org/show_bug.cgi?id=43213

Attachment 63095: Patch
https://bugs.webkit.org/attachment.cgi?id=63095&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> Index: LayoutTests/canvas/philip/tests/2d.composite.operation.clear.html
> ===================================================================
> --- LayoutTests/canvas/philip/tests/2d.composite.operation.clear.html
(revision 64316)
> +++ LayoutTests/canvas/philip/tests/2d.composite.operation.clear.html
(working copy)
> @@ -26,7 +26,7 @@
>  _addTest(function(canvas, ctx) {
>  
>  ctx.globalCompositeOperation = 'xor';
> -ctx.globalCompositeOperation = 'clear';
> +ctx.globalCompositeOperation = 'foobar!';

Changing this test doesn't make a lot of sense given its name, and is separate
from what you're doing here, so this should not be included in the patch.


More information about the webkit-reviews mailing list