[webkit-reviews] review granted: [Bug 43262] style errors in Navigator.h : [Attachment 63073] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 30 12:31:07 PDT 2010


Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 43262: style errors in Navigator.h
https://bugs.webkit.org/show_bug.cgi?id=43262

Attachment 63073: Patch
https://bugs.webkit.org/attachment.cgi?id=63073&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Seems fine to chagne the indentation.

> +    ~Navigator();

This should be explicitly marked virtual. We prefer to do that explicitly even
when we derive from a class where the destructor is already virtual.


More information about the webkit-reviews mailing list