[webkit-reviews] review denied: [Bug 27156] SplitElementCommand shouldn't be duplicating id attribute : [Attachment 63014] fixed the style

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 27156: SplitElementCommand shouldn't be duplicating id attribute
https://bugs.webkit.org/show_bug.cgi?id=27156

Attachment 63014: fixed the style
https://bugs.webkit.org/attachment.cgi?id=63014&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
> +    enum InlineStyleRemovalMode { RemoveAttributesAndElement, RemoveNone };

s/RemoveAttributesAndElement/RemoveAttributesAndElements

> +    bool removeInlineStyleFromElement(CSSMutableStyleDeclaration*,
HTMLElement*, InlineStyleRemovalMode = RemoveAttributesAndElement);
> +    bool removeHTMLFontStyle(CSSMutableStyleDeclaration*, HTMLElement*,
InlineStyleRemovalMode = RemoveAttributesAndElement);
> +    bool removeHTMLBidiEmbeddingStyle(CSSMutableStyleDeclaration*,
HTMLElement*, InlineStyleRemovalMode = RemoveAttributesAndElement);
> +    bool removeCSSStyle(CSSMutableStyleDeclaration*, HTMLElement*,
InlineStyleRemovalMode = RemoveAttributesAndElement);

Typically, returning a boolean value from a method indicates whether it
succeeded or not. In this case, it indicates whether we would have removed
something. Which isn't exactly the same a success. Can we return an enum here
as well?