[webkit-reviews] review granted: [Bug 43250] [IndexedDB] IndexedDatabaseRequest should be called IndexedDatabase : [Attachment 63066] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 30 10:38:10 PDT 2010
Jeremy Orlow <jorlow at chromium.org> has granted Andrei Popescu
<andreip at google.com>'s request for review:
Bug 43250: [IndexedDB] IndexedDatabaseRequest should be called IndexedDatabase
https://bugs.webkit.org/show_bug.cgi?id=43250
Attachment 63066: Patch
https://bugs.webkit.org/attachment.cgi?id=63066&action=review
------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
WebCore/CMakeLists.txt:1436
+ storage/IDBDatabaseBackend.cpp
Wrong!
WebCore/WebCore.vcproj/WebCore.vcproj:50120
+
RelativePath="..\storage\IDBDatabaseBackendImpl.h"
These go first
WebKit/chromium/src/WebIDBDatabaseImpl.h:43
+
WebIDBDatabaseImpl(WTF::PassRefPtr<WebCore::IDBDatabaseBackendInterface>
databaseBackend);
delete variable name
WebCore/storage/IDBRequest.cpp:76
+ void IDBRequest::onSuccess(PassRefPtr<IDBDatabaseBackendInterface>
idbDatabaseBackend)
I think I used some different naming when I did it. Maybe double check in here
and the IDBCallback files that we're consistent. It's fine to do that in the
next renaming patch too.
WebCore/storage/IDBFactoryBackendImpl.cpp:57
+ RefPtr<IDBDatabaseBackendInterface> databaseBackend;
I don't think Backend is needed here, but I don't really care.
r=me
More information about the webkit-reviews
mailing list