[webkit-reviews] review denied: [Bug 43254] Expand SVG Attribute Macros : [Attachment 63067] SVG Attribute Macros Expanded

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Fady Samuel
<fsamuel at chromium.org>'s request for review:
Bug 43254: Expand SVG Attribute Macros
https://bugs.webkit.org/show_bug.cgi?id=43254

Attachment 63067: SVG Attribute Macros Expanded
https://bugs.webkit.org/attachment.cgi?id=63067&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
I'll pick on you, but only because you're new here! :P

WebCore/ChangeLog:10
 +	    No new tests.
Why no new test?

Usually a simple explanation is provided, like:

"No change in behavior, so no new tests."

WebCore/ChangeLog:130
 +	    * rendering/style/SVGRenderStyleDefs.h:
This long list of changes is not very useful. Typically, the author of the
ChangeLog takes this produced template and makes something useful out of it,
like:

rendering/style/SVGRenderStyle.h: Expanded and removed references to <list of
macros> macros.
rendering/style/SVGRenderStyleDefs.h: Removed definitons for expanded macros.

Then you can zap the rest of the list in the template.