[webkit-reviews] review granted: [Bug 42861] Session history should skip over JS redirects : [Attachment 62906] Patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 30 08:20:38 PDT 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 42861: Session history should skip over JS redirects
https://bugs.webkit.org/show_bug.cgi?id=42861
Attachment 62906: Patch v1
https://bugs.webkit.org/attachment.cgi?id=62906&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebCore/loader/RedirectScheduler.cpp:251
+ // See https://webkit.org/b/42861 for the original motivationf for
this.
nit: motivationf -> motivation
LayoutTests/fast/history/gesture-before-onload.html:21
+ document.getElementById('manual-explanation').style.display = '';
nit: indentation
otherwise, r=me (nice work!)
More information about the webkit-reviews
mailing list