[webkit-reviews] review denied: [Bug 43249] [Qt] WebKit2 build system cannot handle generated headers : [Attachment 63056] proposed patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Balazs Kelemen
<kb at inf.u-szeged.hu>'s request for review:
Bug 43249: [Qt] WebKit2 build system cannot handle generated headers
https://bugs.webkit.org/show_bug.cgi?id=43249

Attachment 63056: proposed patch
https://bugs.webkit.org/attachment.cgi?id=63056&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I'm going to say r- because of the other suggested approach. If you still want
to use this approach, then I think at least the addExtraCompiler duplication
should be replaced with a direct use of QMAKE_EXTRA_COMPILERS, as I don't think
any of these copy steps use any of the features that addExtraCompiler() adds to
the regular qmake extra compiler handler.