[webkit-reviews] review requested: [Bug 42827] Use the js-execute-active(entered) Frame to check the user gesture of page instead of checking the top frame : [Attachment 63047] patch V2, change ScriptController::processingUserGesture to static
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 30 04:49:57 PDT 2010
Johnny Ding <jnd at chromium.org> has asked for review:
Bug 42827: Use the js-execute-active(entered) Frame to check the user gesture
of page instead of checking the top frame
https://bugs.webkit.org/show_bug.cgi?id=42827
Attachment 63047: patch V2, change ScriptController::processingUserGesture to
static
https://bugs.webkit.org/attachment.cgi?id=63047&action=review
------- Additional Comments from Johnny Ding <jnd at chromium.org>
I changed the code according to Adam's comments, put the whole logic inside
ScriptController::processingUserGesture and make it as static.
I have run the webkit layout tests(OSX 10.5) and chromium UI test, didn't see
any regressions. So this patch should not affect bug 41350 & bug 41511.
More information about the webkit-reviews
mailing list