[webkit-reviews] review granted: [Bug 42603] Add a mock in WebCore for testing speech input : [Attachment 62977] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted Satish Sampath
<satish at chromium.org>'s request for review:
Bug 42603: Add a mock in WebCore for testing speech input
https://bugs.webkit.org/show_bug.cgi?id=42603

Attachment 62977: Patch
https://bugs.webkit.org/attachment.cgi?id=62977&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
WebCore/platform/mock/SpeechInputClientMock.cpp:34
 +  #include "SpeechInputListener.h"
put inside the #if ENABLE()  (from now on)

WebCore/platform/mock/SpeechInputClientMock.cpp:53
 +	m_timer.startOneShot(0.1);
Why the delay?	Normally we do with 0 delay to make it harder to have flaky
tests.

WebCore/platform/mock/SpeechInputClientMock.cpp:85
 +	    m_timer.startOneShot(0.1);
ditto


r=me
please make just the changes I mentioned and then I'll rubber stamp that +
commit queue it