[webkit-reviews] review requested: [Bug 36734] Implement symbolic CSS3 list-style-types : [Attachment 63028] Patch with test case

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 29 21:30:48 PDT 2010


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 36734: Implement symbolic CSS3 list-style-types
https://bugs.webkit.org/show_bug.cgi?id=36734

Attachment 63028: Patch with test case
https://bugs.webkit.org/attachment.cgi?id=63028&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
I picked the upper bound for the length of a symbolic marker to be lettersSize
:= sizeof(int) * 8 + 1 characters (i.e. the number of characters to represent a
binary number plus a minus sign). Currently, we use a fixed sized array, but we
want to reconsider this and/or special-case symbolics which use more characters
per ordinal than other list style types.


More information about the webkit-reviews mailing list