[webkit-reviews] review granted: [Bug 43213] ctx.clearRect improperly clears shadow : [Attachment 63009] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 43213: ctx.clearRect improperly clears shadow
https://bugs.webkit.org/show_bug.cgi?id=43213

Attachment 63009: Patch
https://bugs.webkit.org/attachment.cgi?id=63009&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    GraphicsContext* c = drawingContext();

I suggest the name "context" here instead of just "c".

> +    c->setShadow(FloatSize(width, -height), state().m_shadowBlur,
state().m_shadowColor, DeviceColorSpace);

I suggest just passing FloatSize(), 0, and Color::transparent instead of
fetching the values we just set in state().

> +    save();
> +    setAllAttributesToDefault();
>      willDraw(rect);
>      c->clearRect(rect);
> +    restore();

Does this extra work hurt performance? How much?