[webkit-reviews] review requested: [Bug 43209] [Qt] QtTestBrowser: -resizes-to-contents command line parameter is broken : [Attachment 63021] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 29 18:54:05 PDT 2010


Antonio Gomes <tonikitoo at webkit.org> has asked	for review:
Bug 43209: [Qt] QtTestBrowser: -resizes-to-contents command line parameter is
broken
https://bugs.webkit.org/show_bug.cgi?id=43209

Attachment 63021: patch v1
https://bugs.webkit.org/attachment.cgi?id=63021&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
When -resizes-to-content was being passed as a command line parameter it was
simply not being set (although the corresponding menu item was marked as ON).
User had to toggle the menu OFF and then ON again for it to take place.

Reason: LauncherWindow::applyPrefs method sets many user options passed in from
the command line, but not resizesToContents. Patch addresses that.


More information about the webkit-reviews mailing list