[webkit-reviews] review granted: [Bug 43222] Setting empty document schemes on the WKContext shouldn't start the WebProcess : [Attachment 63016] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 29 17:39:42 PDT 2010


Sam Weinig <sam at webkit.org> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 43222: Setting empty document schemes on the WKContext shouldn't start the
WebProcess
https://bugs.webkit.org/show_bug.cgi?id=43222

Attachment 63016: Patch
https://bugs.webkit.org/attachment.cgi?id=63016&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
>  
>  void WebContext::registerURLSchemeAsEmptyDocument(const String& urlScheme)
>  {
> -    ensureWebProcess();
> +    if (!hasValidProcess()) {
> +	   m_schemesToRegisterAsEmptyDocument.add(urlScheme);

I think we always want to store these for the crashing case and we shouldn't
clear them after sending. 

Otherwise, r=me.


More information about the webkit-reviews mailing list