[webkit-reviews] review granted: [Bug 40627] Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas) : [Attachment 59800] [PATCH] Part 4 - Client Notification when the Quota is Reached (needs part 3)

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 40627: Limit ApplicationCache Total and Per-Origin Storage Capacity
(Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627

Attachment 59800: [PATCH] Part 4 - Client Notification when the Quota is
Reached (needs part 3)
https://bugs.webkit.org/attachment.cgi?id=59800&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
WebCore/WebCore.OfflineWebApplications.exp

REMINDER: These changes will need to be migrated to WebCore/WebCore.exp.in in
trunk.

WebCore/loader/appcache/ApplicationCacheGroup.cpp:1024
 +	RefPtr<Frame> frameProtector = m_frame;
 +	OriginQuotaReachedCallbackTimer* timer = new
OriginQuotaReachedCallbackTimer(this, frameProtector.get());

Do you really need a frameProtector if the OriginQuotaReachedCallbackTimer
keeps its own RefPtr<> to the frame?

WebKit/WebKit.xcodeproj/project.pbxproj: 
 -		51079D170CED11B00077247D /* WebSecurityOrigin.mm in Sources */
= {isa = PBXBuildFile; fileRef = 51079D140CED11B00077247D /*
WebSecurityOrigin.mm */; };

Please don't delete and the re-add files to the Xcode project file.  It causes
more work when merging later, and creates unnecessary churn.  Please revert the
project file and then move existing files and add the new files to fix this.


WebKit/mac/WebCoreSupport/WebApplicationCacheSecurityOrigin.mm:40
 +	return 0;

Just add the #endif above this line instead of having an #else / return 0; /
#endif.

WebKit/mac/WebCoreSupport/WebApplicationCacheSecurityOrigin.mm:52
 +	return 0;

Ditto.


WebKit/mac/WebView/WebUIDelegatePrivate.h:92
 +  @protocol WebSecurityOriginQuotaManagement;

What is this and where is it defined?!

WebKit/mac/WebView/WebUIDelegatePrivate.h:93
 +  @protocol WebSecurityOriginQuotaManagementUnsigned;

Ditto.	I don't see this used anywhere, either.

WebKit/mac/WebView/WebUIDelegatePrivate.h:127
 +  - (void)webView:(WebView *)sender frame:(WebFrame *)frame
exceededDatabaseQuotaForSecurityOrigin:(WebSecurityOrigin<WebSecurityOriginQuot
aManagement> *)origin database:(NSString *)databaseIdentifier;

I don't see @protocol WebSecurityOriginQuotaManagement defined anywhere.

WebKit/mac/WebView/WebUIDelegatePrivate.h:137
 +  - (void)webView:(WebView *)sender
exceededApplicationCacheOriginQuotaForSecurityOrigin:(WebSecurityOrigin<WebSecu
rityOriginQuotaManagement> *)origin;

Ditto.

r=me assuming you can explain or remove the mysterious @protocols used.  :)