[webkit-reviews] review granted: [Bug 40627] Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas) : [Attachment 59692] [PATCH] Part 2 - Update Schema and enforce Per-Origin Quotas (needs part 1)

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 40627: Limit ApplicationCache Total and Per-Origin Storage Capacity
(Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627

Attachment 59692: [PATCH] Part 2 - Update Schema and enforce Per-Origin Quotas
(needs part 1)
https://bugs.webkit.org/attachment.cgi?id=59692&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
WebCore/loader/appcache/ApplicationCacheStorage.h:87
 +	static const int64_t unknown = -1;

I think this should be called "unknownQuota" to make it more descriptive.


WebCore/loader/appcache/ApplicationCacheStorage.cpp:426
 +	// Using the count to determine if a record existed or not is a safe
way to determine=

Not sure if it's a mail encoding issue, but there is a stray "=" at the end of
"determine" here.


WebCore/loader/appcache/ApplicationCacheStorage.cpp:461
 +		    " WHERE Origins.origin=?"

Please put spaces around the "=" operator (unless this is the prevailing style
for bound values in this file).

WebCore/loader/appcache/ApplicationCacheStorage.cpp:462
 +		    "	AND Caches.id!=?";

Ditto.

WebCore/loader/appcache/ApplicationCacheStorage.cpp:468
 +		    " WHERE Origins.origin=?";

Ditto.


WebCore/loader/appcache/ApplicationCacheStorage.cpp:501
 +	SQLiteStatement updateStatement(m_database, "UPDATE Origins SET quota=?
WHERE origin=?");

Ditto.

r=me