[webkit-reviews] review canceled: [Bug 43166] InsertOrderedList does not switch the list type properly when it has an inner list. : [Attachment 62975] fixed per darin's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 29 15:26:27 PDT 2010


Ryosuke Niwa <rniwa at webkit.org> has canceled Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 43166: InsertOrderedList does not switch the list type properly when it has
an inner list.
https://bugs.webkit.org/show_bug.cgi?id=43166

Attachment 62975: fixed per darin's comments
https://bugs.webkit.org/attachment.cgi?id=62975&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
(In reply to comment #4)
> > Mn.. but doesn't that lead to a memory leak since firstRange() returns a
PassRefPtr?  Because I'm passing the same range object to multiple
doApplyForSingleParagraph in the case of range selection, I don't really want
doApplyForSingleParagraph to take PassRefPtr.
> 
> No, it does not lead to a memory leak. The PassRefPtr that is the result of
the firstRange function goes out of scope after the function returns, and
that's when it calls deref.

I see. Thanks for the clarification. Fixed.


More information about the webkit-reviews mailing list