[webkit-reviews] review denied: [Bug 43204] Add symbol export macros to C++ DOM bindings : [Attachment 62976] Adds export macro to C++ DOM bindings.

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 43204: Add symbol export macros to C++ DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=43204

Attachment 62976: Adds export macro to C++ DOM bindings.
https://bugs.webkit.org/attachment.cgi?id=62976&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
In general this looks fine, but I think you should better align the macros with
the versions in JavaScriptCore/API/JSBase.h.
See JS_EXPORT as example, maybe add a comment to both files that the logic
should stay in sync. The declspec(dllimport) vs. dllexport logic looks reversed
compared to JSBase.h, is this intentional?

You should also grep if there are any other variations of these or similar
macros throughout WebKit (WebCore/JavaScriptCore/WebKit).