[webkit-reviews] review denied: [Bug 5864] feTurbulence is not implemented : [Attachment 62949] SVG feTurbulence imeplementation

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Renata Hodovan
<hodovan at inf.u-szeged.hu>'s request for review:
Bug 5864: feTurbulence is not implemented
https://bugs.webkit.org/show_bug.cgi?id=5864

Attachment 62949: SVG feTurbulence imeplementation
https://bugs.webkit.org/attachment.cgi?id=62949&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Hey Renata,

looks good to me, though I can't r+, as your patch contains unrelated changes
to ResourceHandleMac.mm.

Two issues remaining:
WebCore/svg/graphics/filters/SVGFETurbulence.cpp:140
 +	seed = paintingSeed;
This is superflous, you're already initializing seed a few lines above.

WebCore/svg/graphics/filters/SVGFETurbulence.cpp:141
 +	filterSize = paintingSize;
Ditto.

Please upload a new version, and I'll r+ it. Can you commit on your own? If
not, set cq? next time you upload.