[webkit-reviews] review requested: [Bug 43099] Add JavaScript API to allow a page to go fullscreen : [Attachment 62954] FullScreen-WebCore

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 29 09:05:57 PDT 2010


Jer Noble <jer.noble at apple.com> has asked  for review:
Bug 43099: Add JavaScript API to allow a page to go fullscreen
https://bugs.webkit.org/show_bug.cgi?id=43099

Attachment 62954: FullScreen-WebCore
https://bugs.webkit.org/attachment.cgi?id=62954&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
Figured out the way the new exports mechanism works.  Added the symbols to
WebCore.exp.in instead of ExportFileGenerator.cpp directly.  Also, modified
HTMLIFrameElement.idl so the allowsFullScreen attribute is a boolean type
(instead of a string).


More information about the webkit-reviews mailing list