[webkit-reviews] review denied: [Bug 31115] [Qt] QWebView, QGraphicsWebView and QWebFrame setHtml() should be better documented : [Attachment 62944] Patch for the doc fix, with QGraphicsWebView as well
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 29 07:40:19 PDT 2010
Kenneth Rohde Christiansen <kenneth at webkit.org> has denied review:
Bug 31115: [Qt] QWebView, QGraphicsWebView and QWebFrame setHtml() should be
better documented
https://bugs.webkit.org/show_bug.cgi?id=31115
Attachment 62944: Patch for the doc fix, with QGraphicsWebView as well
https://bugs.webkit.org/attachment.cgi?id=62944&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
WebKit/qt/Api/qgraphicswebview.cpp:715
+ setContent() should be used instead
Misses a dot at the end - both places it is used.
WebKit/qt/Api/qgraphicswebview.cpp:714
+ \warning This function works only for HTML, for other mime types (ex.
XHTML, SVG)
I would use 'ie.' instead of ex. I believe that is more English.
More information about the webkit-reviews
mailing list