[webkit-reviews] review denied: [Bug 5864] feTurbulence is not implemented : [Attachment 62942] SVG feTurbulence imeplementation

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Renata Hodovan
<hodovan at inf.u-szeged.hu>'s request for review:
Bug 5864: feTurbulence is not implemented
https://bugs.webkit.org/show_bug.cgi?id=5864

Attachment 62942: SVG feTurbulence imeplementation
https://bugs.webkit.org/attachment.cgi?id=62942&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Sorry Renata, I missed some obvious issues before:
WebCore/svg/graphics/filters/SVGFETurbulence.cpp:131
 +  FETurbulence::PaintingData::PaintingData(long m_seed, IntSize filterSize)
You shouldn't name arguments passed to a struct with a m_. Use "long
paintingSeed" and "const IntSize& paintingSize".

WebCore/svg/graphics/filters/SVGFETurbulence.cpp:134
 +	filterSize = filterSize;
Ouch! This can't work :-) I've no idea why this ever worked.

I'd suggest to initialize _all_ variables to be sure they are never read
uninitialized:
FETurbulence::PaintingData::PaintingData(long paintingSeed, const IntSize&
paintingSize)
    : seed(paintingSeed)
    , filterSize(paintingSize)
    , width(0)
    , height(0)
    , wrapX(0)
    , wrapY(0)
    , channel(0)
{
}

WebCore/svg/graphics/filters/SVGFETurbulence.h:34
 +	FETURBULENCE_TYPE_UNKNOWN      = 0,
We've stopped lining up these values, just remove the spaces inbetween:
FETURBULENCE_TYPE_UNKNOWN = 0,
..
WebCore/svg/graphics/filters/SVGFETurbulence.cpp:204
 +  float FETurbulence::noise2D(PaintingData& paintingData, FloatPoint
noiseVector)
FloatPoint -> const FloatPoint&.

Okay, I hope these are the last problems, sorry for forcing you for yet another
iteration.