[webkit-reviews] review granted: [Bug 39589] Add LayoutTestController methods to test DeviceOrientation : [Attachment 62934] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 29 03:39:54 PDT 2010


Jeremy Orlow <jorlow at chromium.org> has granted Steve Block
<steveblock at google.com>'s request for review:
Bug 39589: Add LayoutTestController methods to test DeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=39589

Attachment 62934: Patch
https://bugs.webkit.org/attachment.cgi?id=62934&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp:1319
 +  }
ASSERT_NOT_IMPLEMENTED();

WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:448
 +	// See https://bugs.webkit.org/show_bug.cgi?id=30335.
ditto

WebKitTools/DumpRenderTree/mac/LayoutTestControllerMac.mm:326
 +	// See https://bugs.webkit.org/show_bug.cgi?id=30335.
ditto

WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp:690
 +  }
ditto

WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp:381
 +	// See https://bugs.webkit.org/show_bug.cgi?id=30335.
ditto

WebKitTools/DumpRenderTree/wx/LayoutTestControllerWx.cpp:277
 +	// See https://bugs.webkit.org/show_bug.cgi?id=30335.
ditto


r=me


More information about the webkit-reviews mailing list