[webkit-reviews] review denied: [Bug 41732] [Cairo] Bring behavior of paths on the Cairo GraphicsContext into line with the CoreGraphics port : [Attachment 62904] Patch with fewer performance implications

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 41732: [Cairo] Bring behavior of paths on the Cairo GraphicsContext into
line with the CoreGraphics port
https://bugs.webkit.org/show_bug.cgi?id=41732

Attachment 62904: Patch with fewer performance implications
https://bugs.webkit.org/attachment.cgi?id=62904&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
You forgot some context transformations like scale and tranlate. They need to
do path transformation similar to ctm transformation.

Also did you check, if save and restore infulence the path transformations as
well? You can test this with HTML Canvas:
context->translate(10,10);
context->moveTo(0,0);
context->lineTo(100,0);
context->save();
context->scale(0,5);
context->lineTo(100,100);
context->restore();
context->lineTo(0,100);
context->closePath;
context->stroke();

Compare the result with firefox and you'll see if you need extra logic for
save/restore.