[webkit-reviews] review granted: [Bug 42561] Crash when computing pseudo-style of a vanished scrollbar in inspector : [Attachment 62893] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 28 21:59:59 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 42561: Crash when computing pseudo-style of a vanished scrollbar in
inspector
https://bugs.webkit.org/show_bug.cgi?id=42561

Attachment 62893: Patch
https://bugs.webkit.org/attachment.cgi?id=62893&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Thanks for fixing this. I should have mentioning that we were running our own
loop while on a breakpoint.

WebCore/rendering/RenderScrollbar.h:52
 +	void setOwningRenderer(RenderBox* owner) { m_owner = owner; }
Nit: you seem to only use this with 0, maybe you should keep the API less rich
and introduce clearOwningRenderer() instead.


More information about the webkit-reviews mailing list