[webkit-reviews] review requested: [Bug 42843] Interrupt all DB operations when a worker is shutting down : [Attachment 62912] patch

[bugzilla-daemon at webkit.org]

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 42843: Interrupt all DB operations when a worker is shutting down
https://bugs.webkit.org/show_bug.cgi?id=42843

Attachment 62912: patch
https://bugs.webkit.org/attachment.cgi?id=62912&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
> http://wkrietveld.appspot.com/42843/diff/11001/12006#newcode271
> JavaScriptCore/wtf/ThreadingWin.cpp:271: ::SwitchToThread();
> Is SwitchToThread() or Sleep(0) better for our particular use case?

looks like Sleep(1) is better than both SwitchToThread() and Sleep(0).

> http://wkrietveld.appspot.com/42843/diff/11001/12018
> File WebCore/storage/SQLStatement.cpp (right):
> 
> http://wkrietveld.appspot.com/42843/diff/11001/12018#newcode81
> WebCore/storage/SQLStatement.cpp:81: m_error =
SQLError::create(db->isInterrupted() ? SQLError::DATABASE_ERR :
SQLError::SYNTAX_ERR, database->lastErrorMsg());
> Would it make sense to test result for equality with SQLITE_INTERRUPT here
instead of sampling isInterrupted?

done.