[webkit-reviews] review granted: [Bug 43163] Add a CF-style base type (WKTypeRef) as a base for polymorphic functions : [Attachment 62900] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 43163: Add a CF-style base type (WKTypeRef) as a base for polymorphic
functions
https://bugs.webkit.org/show_bug.cgi?id=43163

Attachment 62900: Patch
https://bugs.webkit.org/attachment.cgi?id=62900&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    virtual Type type() const { return TypeArray; }

> +    virtual Type type() const { return TypeString; }

> +    virtual Type type() const { return TypeURL; }

> +    virtual Type type() const { return TypeBackForwardList; }

> +    virtual Type type() const { return TypeBackForwardListItem; }

> +    virtual Type type() const { return TypeContext; }

> +    virtual Type type() const { return TypeFramePolicyListener; }

> +    virtual Type type() const { return TypeFrame; }

> +    virtual Type type() const { return TypeNavigationData; }

> +    virtual Type type() const { return TypePageNamespace; }

> +    virtual Type type() const { return TypePage; }

> +    virtual Type type() const { return TypePreferences; }

> +    virtual Type type() const { return TypeBundleFrame; }

> +    virtual Type type() const { return TypeBundlePage; }

Making this private may catch some callers accidentally calling the virtual
function on something already known to be a WebArray.

> +    operator APIType() { return reinterpret_cast<APIType>(m_impl.get()); }

Doesn't static_cast work for this? If not, why not?