[webkit-reviews] review denied: [Bug 43162] Add support for MADV_FREE to PageAllocation : [Attachment 62898] Errk, better patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 28 17:36:01 PDT 2010
Darin Adler <darin at apple.com> has denied Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 43162: Add support for MADV_FREE to PageAllocation
https://bugs.webkit.org/show_bug.cgi?id=43162
Attachment 62898: Errk, better patch
https://bugs.webkit.org/attachment.cgi?id=62898&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
I think this would be more readable if the #ifs were moved exclusively inside
the commit and decommit functions.
This won't compile because you've left the argument names out even though you
are using them in decommit.
More information about the webkit-reviews
mailing list