[webkit-reviews] review denied: [Bug 43157] First pass at visited link support for WK2 : [Attachment 62891] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Brady Eidson <beidson at apple.com>'s
request for review:
Bug 43157: First pass at visited link support for WK2
https://bugs.webkit.org/show_bug.cgi?id=43157

Attachment 62891: Patch
https://bugs.webkit.org/attachment.cgi?id=62891&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> +
> +void WebHistoryClient::populateVisitedLinks()
> +{
> +    if (!m_contextHistoryClient.populateVisitedLinks)
> +	   return;
> +
> +    m_contextHistoryClient.populateVisitedLinks(toRef(&m_context),
m_contextHistoryClient.clientInfo);
>  }

Instead of storing the context here, I think it makes more sense to just pass
the context the this method as we do everywhere else.
> -	       didNavigateWithNavigationData(webFrame(frameID), store);
> +	      
pageNamespace()->context()->didNavigateWithNavigationData(webFrame(frameID),
store);

I don't think there is any reason for these messages to go to the WebPageProxy,
they should be able to go right to the WebContext from the WebProcessProxy.


r- to address these issues.