[webkit-reviews] review requested: [Bug 43102] Set incorrect but close expectations for mask-colorspace.svg on mac : [Attachment 62791] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 28 16:07:19 PDT 2010


Ojan Vafai <ojan at chromium.org> has asked  for review:
Bug 43102: Set incorrect but close expectations for mask-colorspace.svg on mac
https://bugs.webkit.org/show_bug.cgi?id=43102

Attachment 62791: Patch
https://bugs.webkit.org/attachment.cgi?id=62791&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
(In reply to comment #2)
> Is there a way to get layout test results automatically added to this bug by
a bot? I am afraid the code change may affect the pixel results of a huge
number of tests.

Sorry, I missed this comment. Setting back to r?.

The way you do this currently is to commit the patch and then grab the results
off the bot. But, I'm confused now. Do you expect a lot of tests to change, if
so, why did you include only the one set of new results in the patch?

For the chromium bots, you should include the tests that will fail in
test_expectations.txt with a comment that they'll be removed once results can
be grabbed off the bots.


More information about the webkit-reviews mailing list