[webkit-reviews] review granted: [Bug 43145] Add support for calling NPObject methods : [Attachment 62873] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 28 14:04:10 PDT 2010


Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 43145: Add support for calling NPObject methods
https://bugs.webkit.org/show_bug.cgi?id=43145

Attachment 62873: Patch
https://bugs.webkit.org/attachment.cgi?id=62873&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> +    if (!returnValue)
> +	   throwError(exec, createError(exec, "Error calling method on
NPObject!"));

Do we need the exclamation point?

Otherwise, r=me.


More information about the webkit-reviews mailing list