[webkit-reviews] review granted: [Bug 33814] WebKitTools/Scripts/check-webkit-style gives false positives in single-line functions. : [Attachment 62831] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 28 12:30:57 PDT 2010
Shinichiro Hamaji <hamaji at chromium.org> has granted Kenichi Ishibashi
<bashi at google.com>'s request for review:
Bug 33814: WebKitTools/Scripts/check-webkit-style gives false positives in
single-line functions.
https://bugs.webkit.org/show_bug.cgi?id=33814
Attachment 62831: Patch
https://bugs.webkit.org/attachment.cgi?id=62831&action=review
------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Looks great. I'll make the following changes when I'll land this patch.
WebKitTools/Scripts/webkitpy/style/checkers/cpp_unittest.py:2600
+ '}\n',
I'd put a semicolon so this code is valid as C++.
WebKitTools/Scripts/webkitpy/style/checkers/cpp_unittest.py:2608
+ '}\n',
ditto
More information about the webkit-reviews
mailing list