[webkit-reviews] review requested: [Bug 27156] SplitElementCommand shouldn't be duplicating id attribute : [Attachment 62856] fixed style per darin's comment

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 28 12:06:37 PDT 2010


Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 27156: SplitElementCommand shouldn't be duplicating id attribute
https://bugs.webkit.org/show_bug.cgi?id=27156

Attachment 62856: fixed style per darin's comment
https://bugs.webkit.org/attachment.cgi?id=62856&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
(In reply to comment #15)
> (From update of attachment 62790 [details])
> > +bool
ApplyStyleCommand::removeInlineStyleFromElement(CSSMutableStyleDeclaration
*style, HTMLElement *elem, bool dontRemove)
> 
> I don’t know why the style bot is not complaining about this. The "*"
character should be next to the types.

Ugh... that's why I shouldn't copy & paste to create a new method.  Sorry about
that.

> Please use a word, "element", instead of a word fragment, "elem". In general
we should keep abbreviations to a minimum in new code.

Fixed.


More information about the webkit-reviews mailing list