[webkit-reviews] review requested: [Bug 40425] Web Inspector: provide API for content scripts to interact with the inspector : [Attachment 62843] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 28 10:14:03 PDT 2010


Andrey Kosyakov <caseq at chromium.org> has asked	for review:
Bug 40425: Web Inspector: provide API for content scripts to interact with the
inspector
https://bugs.webkit.org/show_bug.cgi?id=40425

Attachment 62843: patch
https://bugs.webkit.org/attachment.cgi?id=62843&action=review

------- Additional Comments from Andrey Kosyakov <caseq at chromium.org>
- Removed magic strings when sending notifications on server side and when
creating statuses
- Do not attach panel upon creation
- Invoke callbacks right after client iframes are created, not in their onload
(to support detached panels; may need ExtensionPanel.onLoad and
ExtensionSidebarPane.onLoad)
- Hidden internal fields in API classes in closures
- Added dumping API fields in layout tests
- JSON.stringify everything resulting from eval in inspected page
- Removed webInspector.panels.get()


More information about the webkit-reviews mailing list